Lang German added #165
Lang German added #165
Conversation
|
Thanks a lot @Laurin-migi 👍 Any reason why this PR is targeting v2/main (Umbraco 8) and not v4/main (Umbraco 10+)? |
yes, thats because we use umbraco v8 and we will use umvraco 10 later. When I have time, I will make a new PR with v10 |
There was a problem hiding this comment.
Hi @Laurin-migi
I've found a minor issue. Even for the German translation, this is supposed to be the English word Content, right?
If you can look into this, I'd be happy to merge, and then push a new release for Umbraco 8 😉
| <key alias="reload">Neu laden</key> | ||
| <key alias="edit">Bearbeiten</key> | ||
| <key alias="delete">Löschen</key> | ||
| <key alias="content">Contet</key> |
There was a problem hiding this comment.
Shouldn't this be Content like line 40?
limbobot
added
umbraco/v8
|
Hi @Laurin-migi Thanks so much for submitting this pull request and helping to improve the package! We had asked for some additional information, but since we haven’t heard back from you, we’ll go ahead and close this PR for now to keep things organized. If you’d like to revisit it, don’t hesitate to reopen the PR or create a new one when you’re ready. We’re grateful for your contribution and hope to see more from you in the future. 😊 |
I come from Switzerland and have therefore added a German language to your great package.